Edit: see pinned comment for update

Hello All,

Due to the incredibly irresponsible disclosure of a security vulnerability for Piefed, we’ve had to take Piefed.zip offline until a fix can be put in place.

I’ll update more once I have more information.

Many thanks

Demigodrick

  • Demigodrick@lemmy.zip
    shield
    OPM
    link
    fedilink
    English
    arrow-up
    0
    ·
    4 months ago

    Update: there are additional reported vulnerabilities that I have been made aware of.

    These have been shared with the Piefed Dev but no fixes yet in place.

    Given this knowledge and the fact these exploits could be used to target vulnerable users and potentially access account data, I feel it is sensible to keep the instance offline until further fixes are in place.

  • Schwim Dandy@lemmy.zip
    link
    fedilink
    English
    arrow-up
    0
    ·
    5 months ago

    Hi there @Demigodrick@lemmy.zip , is there any way to use the piefed.zip export to import to lemmy.zip? I tried since it was mentioned in the email but it just states that the import failed when I try.

    Just wondering if I can modify or remove some elements of the file so I can use it to get the blocks and subs imported from my piefed account.

    Thanks!

  • FrederikNJS@lemmy.zip
    link
    fedilink
    English
    arrow-up
    0
    ·
    5 months ago

    Thank you for taking proactive measures. I hope it gets resolved soon.

    Are there any information around the nature of the vulnerability or the status of a fix?

  • fiat_lux@lemmy.zip
    link
    fedilink
    English
    arrow-up
    0
    ·
    5 months ago

    A few months ago I mentioned in a thread about Piefed there were questionable system design choices that indicated that other parts of the system should be carefully examined for how they’re handling and sanitizing input. I’m assuming someone discovered one of the places that this was actively exploitable.

    From what I’ve seen of the code, although Python is not my specialty, it might be worth delaying reactivation until it can demonstrate that it is at least somewhat resistant to the OWASP Top 10, especially Injection.

    Irresponsible disclosure is annoying, but vastly better than discovery and exploitation by those who aren’t going to disclose at all.

    • Blaze (he/him)@lemmy.zip
      link
      fedilink
      English
      arrow-up
      0
      ·
      4 months ago

      You can look at https://codeberg.org/rimu/pyfedi/releases/tag/v1.6.25 to see the changes.

      Basically, the 0-day was mostly someone running an LLM and trying to discover vulnerabilities without double checking them. Most of the things reported were not applicable (mentioning functions that don’t even exist), others were not applicable but led to some tangent hardening.

      Lemmy also had a SSRF vulnerability a month ago: https://github.com/LemmyNet/lemmy/security/advisories/GHSA-q537-8fr5-cw35

      • fiat_lux@lemmy.zip
        link
        fedilink
        English
        arrow-up
        0
        ·
        4 months ago

        The raw changes are interesting but not particularly descriptive of the problem(s?) it intends to resolve, so I can’t gauge whether it achieves the goal from this. The description of the version bump as simply “security improvements” doesn’t help me determine if any of these changes add dedicated tests or anything else to prevent future occurrences (and I’m not traversing the repository on my phone). Additionally, the issue acknowledged via inline comment: “This will probably break PeerTube federation” is odd to omit from even the briefest changelog. In my opinion, this is not that reassuring an update.

        The LLM generated report of Lemmy’s vulnerability, which I note requires an entire DNS configuration to exploit, is a little ironic to point to as an authoritative source while characterizing the Piefed exploit discovery as “someone running an LLM and trying to discover vulnerabilities without double checking them”.

        But I don’t think it’s necessary or helpful to have a competitive security score-card situation between packages either - I would much prefer that each ActivityPub implementation is meaningfully improving their development lifecycle processes, especially around security risk mitigation, even if they don’t go quite as far as having a formal “security posture”.

    • Blaze (he/him)@piefed.social
      link
      fedilink
      English
      arrow-up
      0
      ·
      4 months ago

      You can look at https://codeberg.org/rimu/pyfedi/releases/tag/v1.6.25 to see the changes.

      Basically, the 0-day was mostly someone running an LLM and trying to discover vulnerabilities without double checking them. Most of the things reported were not applicable (mentioning functions that don’t even exist), others were not applicable but led to some tangent hardening.

      Lemmy also had a SSRF vulnerability a month ago: https://github.com/LemmyNet/lemmy/security/advisories/GHSA-q537-8fr5-cw35

  • U7826391786239@lemmy.zipdeleted by creator
    link
    fedilink
    English
    arrow-up
    0
    ·
    4 months ago

    honestly i started using piefed because A) there’s a .zip instance; and B) it’s easier to follow people

    given these security problems on top of the main dev’s drama, i’ll probably just delete my piefed and move back to lemmy

    • frongt@lemmy.zip
      link
      fedilink
      English
      arrow-up
      0
      ·
      4 months ago

      I’m on my phone so I can’t review the issues, but I’m guessing they’re mostly about the web interface. I would just not expose that to the world, only expose the necessary federation API endpoints.

  • sirxdaemon@lemmy.ca
    link
    fedilink
    English
    arrow-up
    0
    ·
    5 months ago

    Appreciate the email on this. I don’t think I got an email from Piefed.social either. Heck I don’t remember getting any from Lemmy.ca for Lemmy downtime. But perhaps they haven’t ran into a similar situation.