• 2 Posts
  • 10 Comments
Joined 3 years ago
cake
Cake day: June 12th, 2023

help-circle








  • Everything gets reviewed. If you have a constructive comment you put it in the review.

    I’m a tech lead now so that’s basically the end although if they want to argue their case I’ll hear them out.

    So basically you’re saying that all the comments are welcome, and should be argued, but you have to appoint a person that have the final say on what to merge right?

    I’m not sure what problem you think is being moved to the reviewer.

    The problem of deciding what should be merged or blocked, I’ve mainly made this post to understand that, so saying “#5 or you’re crazy” doesn’t answer much. But I’ve probably worded that badly.


  • Ok then you’re moving the problem to the reviewer, what change request would you say is a mandatory fix? In the place you worked, were you marking the comments on the review in any way to make them mandatory / non mandatory? Or just discussing them one by one?

    Edit: given the amount of downvotes let me clarify this comment is not trying to be polemical, I’m genuinely asking the above questions.